What is a "Nit" in a code review?

What is a "nit" in the code review world?

A nit is a small, insignificant issue spotted during a code review process that doesn't have a major impact on the overall quality of the code.

Developers use the "nit:" prefix as a shorthand for nitpicking in code review comments.

A nit can still be corrected to improve the code's clarity, readability, or maintainability.

Good practice

You may ask: If it's a minor thing, why even bother?

Well, minor things add up. Especially in a large codebase. If you let it slide too many times, you end up with code spaghetti 🍝.

I think every developer should use "nits".

They are a great way to follow the best practices of code reviews. They let you be nice and share knowledge with your fellow developers.

Code Review "Nit" Examples

Some examples of nits in code reviews include:

• Minor typos in comments or variable names
• Spelling errors
• Inconsistent use of whitespace or indentation
• Use of shorthand notation that is difficult for others to understand
• Redundant code comments
• Use of long lines of code that could be broken up for improved readability
• Use of a function or method that has a slightly more efficient alternative

Issue vs Nit

Serious issues are those that could impact the code's functionality, reliability, security, or performance. Nits, on the other hand, are minor issues that may not affect the code's overall quality or functionality.

I've been there so many times.

I usually take a step back and think about the potential impact it could have on the code.

• How frequently do we change that code area?
  • It might seem like a nit today, but it could snowball.
• Is the code still easy to understand?
  • Ensuring that code is understandable is top 3 reasons for a code review.

No matter how big or small the issue is, it's always a good idea to address it.

By taking care of nits early on, you can prevent them from becoming problems down the road.